From: Christoph Berg <myon@debian.org>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: fast defaults in heap_getattr vs heap_deform_tuple
Date: Wed, 6 Feb 2019 13:22:29 +0100
Message-ID: <20190206122229.GB10563@msg.df7cb.de> (raw)
In-Reply-To: <20190206113919.64ihpul63brrg4y6@alap3.anarazel.de>
References: <20190201162404.onngi77f26baem4g@alap3.anarazel.de>
<20190201224905.3qkbm5gj6ielsszc@alap3.anarazel.de>
<6b0f583f-cfa9-c476-86bf-6976f1c41b2a@2ndQuadrant.com>
<20190205165705.7cqrwvjxvip7dcow@alap3.anarazel.de>
<20190206091740.gdohil2mpdmzf7z5@alap3.anarazel.de>
<87va1x43ot.fsf@news-spur.riddles.org.uk>
<20190206113919.64ihpul63brrg4y6@alap3.anarazel.de>
> > Sorry I didn't spot this earlier, but... in the backpatch to v11, is the
> > expansion of the trigger tuple really unnecessary now? Since
> > heap_getattr is a macro, C-language triggers that aren't recompiled
> > won't see the default? So perhaps the expansion should be left in?
>
> Myon | the list of packages in Debian where heap_getattr appears is postgresql-11, pglogical,
> | pgextwlist, citus, postgresql-plsh, wal2json, pg-cron, postgresql-rum
>
> I'm mildly disinclined to re-add the heap_expand_tuple, because it's not
> the only case, and the extensions named above don't seem like they'd
> specifically affected by the trigger path, but I'm not sure.
I'm not following closely enough to say anything about which fix is
the best, but if this isn't a "recompile the world" case, we can get
the above list of packages rebuilt. It would be rather unpleasant to
have to schedule that for 50 packages, though.
Are rebuilt extension binaries compatible with older servers that do
not have the fix yet?
Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: myon@debian.org, andres@anarazel.de, andrew@tao11.riddles.org.uk, andrew.dunstan@2ndquadrant.com
Subject: Re: fast defaults in heap_getattr vs heap_deform_tuple
In-Reply-To: <20190206122229.GB10563@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox