From: Michael Paquier <michael@paquier.xyz>
To: Michael Banck <michael.banck@credativ.de>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: [Patch] checksumming-related buglets in pg_verify_checksums/pg_basebackup TAP tests
Date: Mon, 18 Feb 2019 14:25:03 +0900
Message-ID: <20190218052503.GL15532@paquier.xyz> (raw)
In-Reply-To: <1550153276.796.35.camel@credativ.de>
References: <1550153276.796.35.camel@credativ.de>
On Thu, Feb 14, 2019 at 03:07:56PM +0100, Michael Banck wrote:
> This also revealed a second bug in the pg_basebackup test suite where
> the offset for the corruption in the second file was wrong, so it
> actually never got corrupted, and the tests only passed due to the above
> twice than expected number of written bytes. The write() probably
> overflowed into an adjacent block so that the total number of corrupted
> blocks was as expected by accident. Oops, my bad, patch attached.
Fixed and back-patched where adapted, thanks! ee9e145 was a first
shot for a fix in pg_basebackup tests, but it has missed one seek()
call.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, michael.banck@credativ.de, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
Subject: Re: [Patch] checksumming-related buglets in pg_verify_checksums/pg_basebackup TAP tests
In-Reply-To: <20190218052503.GL15532@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox