From: David Fetter <david@fetter.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: psql show URL with help
Date: Sun, 3 Mar 2019 22:48:33 +0100
Message-ID: <20190303214833.GD10435@fetter.org> (raw)
In-Reply-To: <CABUevEyc98E-Jxq-S5jEttiwrdxkAZbpUNsoEt5=DwgVqauY5g@mail.gmail.com>
References: <40179bd0-fa7d-4108-1991-a20ae9ad5667@2ndquadrant.com>
<47e071fd-8997-f036-b383-4d80c184adeb@2ndquadrant.com>
<a8df897e-f1df-b539-a85d-298c678d4180@2ndquadrant.com>
<20190303181432.GA316@fetter.org>
<CABUevEyc98E-Jxq-S5jEttiwrdxkAZbpUNsoEt5=DwgVqauY5g@mail.gmail.com>
On Sun, Mar 03, 2019 at 09:57:25PM +0100, Magnus Hagander wrote:
> On Sun, Mar 3, 2019 at 7:14 PM David Fetter <david@fetter.org> wrote:
>
> > On Wed, Feb 27, 2019 at 09:14:59AM +0100, Peter Eisentraut wrote:
> > > + url = psprintf("
> > https://www.postgresql.org/docs/%s/%s.html";,
> > > +
> > strstr(PG_VERSION, "devel") ? "devel" : PG_MAJORVERSION,
> > > +
> > QL_HELP[i].docbook_id);
> >
> > Do we need to make sure that the docs are published under the major
> > version as soon as we get to alpha, or do we need something more like
> > this?
> >
> > url = psprintf("https://www.postgresql.org/docs/%s/%s.html";,
> > (strstr(PG_VERSION, "devel") || strstr(PG_VERSION, "beta") ||
> > strstr(PG_VERSION, "alpha")) : "devel" : PG_MAJORVERSION,
> > QL_HELP[i].docbook_id);
> >
>
> We don't really release alphas any more. And we do load the documentation
> alongside the betas. (Last time we did an alpha was so long ago I don't
> remember if we loaded docs)
If the first thing we do when we move from devel to some other state
(beta, RC, etc.) is to publish the docs under the major version
number, then maybe this test should be more along the lines of looking
for anything that's neither devel nor a number, extract the number,
and use that.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@fetter.org, magnus@hagander.net, peter.eisentraut@2ndquadrant.com
Subject: Re: psql show URL with help
In-Reply-To: <20190303214833.GD10435@fetter.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox