From: Christoph Berg <myon@debian.org>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
Date: Fri, 8 Mar 2019 14:02:34 +0100
Message-ID: <20190308130234.GD11419@msg.df7cb.de> (raw)
In-Reply-To: <3eb194cf-b878-1f63-8623-6d6add0ed0b7@2ndquadrant.com>
References: <20190218143028.GA3700@alvherre.pgsql>
<28360.1550506699@sss.pgh.pa.us>
<20190221093702.GA5238@msg.df7cb.de>
<3eb194cf-b878-1f63-8623-6d6add0ed0b7@2ndquadrant.com>
Re: Peter Eisentraut 2019-03-08 <3eb194cf-b878-1f63-8623-6d6add0ed0b7@2ndquadrant.com>
> On 2019-02-21 10:37, Christoph Berg wrote:
> > diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
> > index a18a6f6c45..8080626e94 100644
> > --- a/src/test/regress/pg_regress.c
> > +++ b/src/test/regress/pg_regress.c
> > @@ -1794,12 +1794,14 @@ run_schedule(const char *schedule, test_function tfunc)
> > else
> > {
> > status(_("FAILED"));
> > + status(" "); /* align with failed (ignored) */
> > fail_count++;
> > }
>
> So an issue here is that in theory "FAILED" etc. are marked for
> translation but your spacers do not take that into account. Personally,
> I have no ambition to translate pg_regress, so we could remove all that.
> But it should be done consistently in either case.
Oh, right. So the way to go would be to use _("FAILED "), and
ask translators to use the same length.
> I also think we shouldn't worry about the "failed (ignored)" case. That
> never happens, and I don't want to mess up the spacing we have now for
> that. I'd consider removing support for it altogether.
You mean removing that case from pg_regress, or removing the alignment
"support"?
Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: myon@debian.org, peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
In-Reply-To: <20190308130234.GD11419@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox