From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Chapman Flack <chap@anastigmatix.net>
Cc: Markus Winand <markus.winand@winand.at>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PostgreSQL vs SQL/XML Standards
Date: Fri, 8 Mar 2019 15:34:17 -0300
Message-ID: <20190308183417.GA4442@alvherre.pgsql> (raw)
In-Reply-To: <CAFj8pRDW_vqQxoyEz31b5r_fQvzMzwOm=KaVjJtJDm12_wzxXQ@mail.gmail.com>
(I spent some time trying to reproduce the original bug, but was
interrupted for lunch before getting a useful installation. I find it a
bit strange that it doesn't crash in x86_64, mind ...)
On 2019-Mar-08, Pavel Stehule wrote:
> It fixes current issue, but I afraid so these two routines are not
> replaceable. xmlFreeNodeList doesn't release xmlFreeDtd, XML_ATTRIBUTE_NODE
> is not checked.
:-(
> Maybe we can call explicitly xmlFreeDoc instead xmlFreeNode
>
> some like
>
> if (cur_copy->type == XML_DOCUMENT_NODE)
> xmlFreeDoc((xmlDocPtr) cur_copy);
> else
> xmlFreeNode(cur_copy);
>
> This looks most correct fix for me. What do you think?
Seems like that should work, yeah ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, pavel.stehule@gmail.com, chap@anastigmatix.net, markus.winand@winand.at, pgsql-hackers@lists.postgresql.org
Subject: Re: PostgreSQL vs SQL/XML Standards
In-Reply-To: <20190308183417.GA4442@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox