pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Offline enabling/disabling of data checksums
Date: Wed, 13 Mar 2019 19:10:21 +0900
Message-ID: <20190313101021.GF2988@paquier.xyz> (raw)
In-Reply-To: <alpine.DEB.2.21.1903131037240.4059@lancre>
References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de>
	<20190311045323.GE1818@paquier.xyz>
	<155231347133.16480.11453587097036807558.pgcf@coridan.postgresql.org>
	<1552385626.4947.50.camel@credativ.de>
	<20190312124403.GM13812@paquier.xyz>
	<20190313021621.GP13812@paquier.xyz>
	<alpine.DEB.2.21.1903130805330.4059@lancre>
	<20190313093150.GE2988@paquier.xyz>
	<alpine.DEB.2.21.1903131037240.4059@lancre>

On Wed, Mar 13, 2019 at 10:44:03AM +0100, Fabien COELHO wrote:
> Yep. That is the issue I think is preventable by fsyncing updated data
> *then* writing & syncing the control file, and that should be done by
> pg_checksums.

Well, pg_rewind works similarly: control file gets updated and then
the whole data directory gets flushed.  In my opinion, the take here
is that we log something after the sync of the whole data folder is
done, so as in the event of a crash an operator can make sure that
everything has happened.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (149+ messages)  latest in thread

Message-ID: <20190313101021.GF2988@paquier.xyz>
Permalink:  ../20190313101021.GF2988@paquier.xyz/
Also on:    postgresql.org/message-id/20190313101021.GF2988@paquier.xyz

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, coelho@cri.ensmp.fr, michael.banck@credativ.de, sk@zsrv.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Offline enabling/disabling of data checksums
  In-Reply-To: <20190313101021.GF2988@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox