From: Justin Pryzby <pryzby@telsasoft.com>
To: David Steele <david@pgmasters.net>
Cc: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Re: query logging of prepared statements
Date: Wed, 20 Mar 2019 08:28:34 -0500
Message-ID: <20190320132833.GB2952@telsasoft.com> (raw)
In-Reply-To: <2da70a91-2a22-9d78-84ba-cba4b71c7541@pgmasters.net>
References: <20190208132953.GF29720@telsasoft.com>
<20190215145704.GW30291@telsasoft.com>
<20190227180653.GF28750@telsasoft.com>
<70868e0d-2a29-36c8-e3e2-f54a56804bc4@postgrespro.ru>
<20190304183150.GK29584@telsasoft.com>
<345f3504-e3cd-3a01-c593-ebbbe555dd69@postgrespro.ru>
<2da70a91-2a22-9d78-84ba-cba4b71c7541@pgmasters.net>
Hi,
On Wed, Mar 20, 2019 at 02:46:00PM +0400, David Steele wrote:
> >I perfectly understand your use case. I agree, it is duplicated. But I
> >think some people may want to see it at every EXECUTE, if they don't want
> >to grep for the prepared statement body which was logged earlier.
> >
> >I think it would be good to give possibility to configure this behavior.
> >At first version of your patch you relied on log_error_verbosity GUC. I'm
> >not sure that this variables is suitable for configuring visibility of
> >prepared statement body in logs, because it sets more general behavior.
> >Maybe it would be better to introduce some new GUC variable if the
> >community don't mind.
>
> Thoughts on this?
I'm happy to make the behavior configurable, but I'm having trouble believing
many people would want a GUC added for this. But I'd be interested to hear
input on whether it should be configurable, or whether the original "verbose"
logging is desirable to anyone.
This is mostly tangential, but since writing the original patch, I considered
the possibility of a logging GUC which is scales better than log_* booleans:
https://www.postgresql.org/message-id/20190316122422.GR6030%40telsasoft.com
If that idea were desirable, there could be a logging_bit to enable verbose
logging of prepared statements.
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, david@pgmasters.net, a.zakirov@postgrespro.ru
Subject: Re: Re: query logging of prepared statements
In-Reply-To: <20190320132833.GB2952@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox