From: Christoph Berg <myon@debian.org>
To: David Steele <david@pgmasters.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Re: Reporting script runtimes in pg_regress
Date: Thu, 21 Mar 2019 12:51:00 +0100
Message-ID: <20190321115059.GF2687@msg.df7cb.de> (raw)
In-Reply-To: <8a85bece-b18f-0433-acf3-d106b31f0271@pgmasters.net>
References: <20190308131217.GA13043@alvherre.pgsql>
<8a85bece-b18f-0433-acf3-d106b31f0271@pgmasters.net>
Re: David Steele 2019-03-20 <8a85bece-b18f-0433-acf3-d106b31f0271@pgmasters.net>
> > > Oh, right. So the way to go would be to use _("FAILED "), and
> > > ask translators to use the same length.
> >
> > Note there's no translation for pg_regress. All these _() markers are
> > currently dead code. It seems hard to become motivated to translate
> > that kind of program. I don't think it has much value, myself.
>
> This patch has been "Waiting on Author" since March 8th. Do you know when
> you'll have a new version ready?
Here is a new revision that blank-pads "ok" to the length of "FAILED".
Christoph
Attachments:0001-Align-timestamps-in-pg_regress-output.patch (text/x-diff, 889B) download
From cd2a5927b52473ca9c56e2e5142c257853429224 Mon Sep 17 00:00:00 2001
From: Christoph Berg <christoph.berg@credativ.de>
Date: Thu, 21 Feb 2019 10:35:19 +0100
Subject: [PATCH] Align timestamps in pg_regress output
---
src/test/regress/pg_regress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.cindex a18a6f6c45..8111d95b1e 100644--- a/src/test/regress/pg_regress.c+++ b/src/test/regress/pg_regress.c@@ -1799,7 +1799,7 @@ run_schedule(const char *schedule, test_function tfunc)
}
else
{
- status(_("ok"));+ status(_("ok ")); /* align with FAILED */
success_count++;
}
@@ -1879,7 +1879,7 @@ run_single_test(const char *test, test_function tfunc)
}
else
{
- status(_("ok"));+ status(_("ok ")); /* align with FAILED */
success_count++;
}
--
2.20.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: myon@debian.org, david@pgmasters.net, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: Re: Reporting script runtimes in pg_regress
In-Reply-To: <20190321115059.GF2687@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox