From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Donald Dong <xdong@csumb.edu>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: Unified logging system for command-line programs
Date: Tue, 2 Apr 2019 17:48:24 -0300
Message-ID: <20190402204824.GA24717@alvherre.pgsql> (raw)
In-Reply-To: <7474.1554236240@sss.pgh.pa.us>
On 2019-Apr-02, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > I don't much like the code that does
> > pg_log_error("%s", something);
>
> > because then the string "%s" is marked for translation.
>
> Uh, surely we've got hundreds of instances of that in the system already?
Actually, we don't have that many, but there are more than I remembered
there being -- my memory was telling me that I had erradicated them all
in commit 55a70a023c3d but that's sadly misinformed. Seeing this (and
also because the API would become nastier than I thought it would), I'll
leave this stuff be for now.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, xdong@csumb.edu, andres@anarazel.de
Subject: Re: Unified logging system for command-line programs
In-Reply-To: <20190402204824.GA24717@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox