pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Shawn Debnath <sdn@amazon.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Refactoring the checkpointer's fsync request queue
Date: Wed, 3 Apr 2019 21:19:45 -0700
Message-ID: <20190404041945.GA16205@f01898859afd.ant.amazon.com> (raw)
In-Reply-To: <CA+hUKG+2Uri6dzddX3_K2mpWT3dRz-3Dzoja3-a3=3EYrvGEYg@mail.gmail.com>
References: <20190313010007.GB8301@f01898859afd.ant.amazon.com>
	<CA+hUKGL_sOaYRqnvbKYK5jYRx1faqrtCg8uiJ2V1DDX9BDs6Dg@mail.gmail.com>
	<CA+hUKG+6dLs2Ok1+wnq5PKLMw2N8t99wuHzoEYqod9cDWKuznw@mail.gmail.com>
	<CA+Tgmob19umNQogKHknsG+smLUZeHihNAk-h+KxPd82SDi10WQ@mail.gmail.com>
	<20190326164758.GA78630@f01898859afd.ant.amazon.com>
	<CA+hUKG+=vJEEFYG_OyGScdPVy2Lw+MEk9aNHPCSiaa58QoxjJA@mail.gmail.com>
	<CA+hUKG+1k+sWCPVgBe0M9BR9e4hBva5ODWCydY7R8v02C6KOAQ@mail.gmail.com>
	<20190403214423.GA45392@f01898859afd.ant.amazon.com>
	<CA+hUKG+=-p4oiNC=U6yjtDigAvTXxGbe2__c=cVSxdxZYBxTPQ@mail.gmail.com>
	<CA+hUKG+2Uri6dzddX3_K2mpWT3dRz-3Dzoja3-a3=3EYrvGEYg@mail.gmail.com>

On Thu, Apr 04, 2019 at 02:01:14PM +1300, Thomas Munro wrote:
> On Thu, Apr 4, 2019 at 11:39 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> > ... Perhaps
> > that is an argument for putting the sync handler number *inside* the
> > FileTag, since we currently intend to do that with smgr IDs in
> > BufferTag (stealing space from ForkNumber).
> 
> Here is a version like that.  I like it better this way, and the extra
> space can be clawed back by using 16 bit types to hold the fork number
> and sync handler number.

+typedef struct FileTag
+{
+	int16		handler;		/* SyncRequstHandler value, saving space */
+	int16		forknum;		/* ForkNumber, saving space */
+	RelFileNode rnode;
+	BlockNumber segno;
+} FileTag;

Definitely makes sense. v16 looks good to me.

Thanks!

-- 
Shawn Debnath
Amazon Web Services (AWS)





view thread (87+ messages)  latest in thread

Message-ID: <20190404041945.GA16205@f01898859afd.ant.amazon.com>
Permalink:  ../20190404041945.GA16205@f01898859afd.ant.amazon.com/
Also on:    postgresql.org/message-id/20190404041945.GA16205@f01898859afd.ant.amazon.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: sdn@amazon.com, thomas.munro@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, 9erthalion6@gmail.com
  Subject: Re: Refactoring the checkpointer's fsync request queue
  In-Reply-To: <20190404041945.GA16205@f01898859afd.ant.amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox