From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Date: Thu, 4 Apr 2019 14:45:20 -0700
Message-ID: <20190404214520.7rfufsubxekodypr@alap3.anarazel.de> (raw)
In-Reply-To: <20190404192308.mumsbtmccqyuebdh@alap3.anarazel.de>
References: <20190404172417.gua2xmn754uoxzto@alap3.anarazel.de>
<20190404191554.GA7161@alvherre.pgsql>
<20190404192308.mumsbtmccqyuebdh@alap3.anarazel.de>
Hi,
On 2019-04-04 12:23:08 -0700, Andres Freund wrote:
> Also, how is this code even close to correct?
> CheckAndSetPageAllVisible() modifies the buffer in a crucial way, and
> there's no WAL logging? Without even a comment arguing why that's OK (I
> don't think it is)?
Peter Geoghegan just reminded me over IM that there's actually logging
inside log_heap_visible(), called from visibilitymap_set(). Still lacks
a critical section though.
I still think this is the wrong architecture.
Greetings,
Andres Freund
PS: We're going to have to revamp visibilitymap_set() soon-ish - the
fact that it directly calls heap routines inside is bad, means that
additional AMs e.g. zheap has to reimplement that routine.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, alvherre@2ndquadrant.com, pavan.deolasee@gmail.com, sawada.mshk@gmail.com, jeff.janes@gmail.com, simon@2ndquadrant.com, tomas.vondra@2ndquadrant.com
Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
In-Reply-To: <20190404214520.7rfufsubxekodypr@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox