From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: John Naylor <john.naylor@2ndquadrant.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Oleg Bartunov <obartunov@postgrespro.ru>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: David Steele <david@pgmasters.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: jsonpath
Date: Tue, 9 Apr 2019 18:15:57 +0200
Message-ID: <20190409161557.xwc4xwqeaimxcb4d@development> (raw)
In-Reply-To: <CAPpHfduP2ShBe3r80u0zsOGxRG1XRd4c7PTj-iPfmv4DzL2dyQ@mail.gmail.com>
References: <CAPpHfdvkMdV_nQR3gO41GWJS=2Gjdrm6QhhYH2DwXJ+fMa6gBw@mail.gmail.com>
<23e82578-b648-ab57-a4af-791abccff344@2ndQuadrant.com>
<dcff626f-d44d-ad96-ecc0-109601e2cfb9@2ndQuadrant.com>
<4971.1553779874@sss.pgh.pa.us>
<5656.1553781027@sss.pgh.pa.us>
<b2e3d035-4f42-4670-97ad-e79727c40960@2ndQuadrant.com>
<CAPpHfdu-MvmN9pJnTtTCyuzbcF4t2K4hsfMdEtTGjfx7ZbGVYw@mail.gmail.com>
<CAPpHfdue-pzzEVK+zoY6sbqG4LYC3JvW7-j8J78EqT-TOLdNiw@mail.gmail.com>
<19611.1554593792@sss.pgh.pa.us>
<CAPpHfduP2ShBe3r80u0zsOGxRG1XRd4c7PTj-iPfmv4DzL2dyQ@mail.gmail.com>
On Sun, Apr 07, 2019 at 03:03:58AM +0300, Alexander Korotkov wrote:
>On Sun, Apr 7, 2019 at 2:37 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
>> > Thus, contents of unused function makes test fail or pass. So far, it
>> > looks like a compiler bug. Any thoughts?
>>
>> Yeah :-(. The fact that we've not seen a similar failure on any other
>> machines points in that direction, too. Maybe it's some other aspect
>> of the machine's toolchain, like flex or bison, but that's not that
>> much different from our standpoint.
>>
>> There's a lot of stuff I don't especially like about jsonpath_scan,
>> for instance I think the "init" arguments to resizeString etc are
>> a pretty error-prone and unmaintainable way to do things. But
>> I don't see anything that looks like it'd be a portability hazard
>> that would explain this.
>>
>> I still have a nagging feeling that there's a wild store somewhere
>> in here, but I don't know how to find it based on the limited
>> evidence we've got.
>
>Yeah, it might be not because compiler error. It might depend on
>memory layout. So existence of extra function changes memory layout
>and, in turn, causes an error. I will try to disassemble
>jsonpath_scan.o and see whether content of yyparse2 influences
>assembly of other functions.
>
Have you tried other compiler version / different optimization level? Or
running it under valgrind. Not sure how difficult that is on Windows.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, a.korotkov@postgrespro.ru, tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, john.naylor@2ndquadrant.com, jeff.janes@gmail.com, n.gluhov@postgrespro.ru, obartunov@postgrespro.ru, michael@paquier.xyz, s.kelvich@postgrespro.ru, thomas.munro@enterprisedb.com, david@pgmasters.net, robertmhaas@gmail.com, pavel.stehule@gmail.com
Subject: Re: jsonpath
In-Reply-To: <20190409161557.xwc4xwqeaimxcb4d@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox