pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: hyrax vs. RelationBuildPartitionDesc
Date: Wed, 10 Apr 2019 15:42:20 +0900
Message-ID: <20190410064220.GD2728@paquier.xyz> (raw)
In-Reply-To: <CA+Tgmob=HVg+tvF5XyWW060K3XJsc-y1JdTOAVXk6zLGkHGQiQ@mail.gmail.com>
References: <CA+TgmoaZ021fRZawzU_gozwgHMo-tXJc12uf3MJoA6k=HZsLJA@mail.gmail.com>
	<10788.1552501588@sss.pgh.pa.us>
	<CA+TgmoYd3vqd26RiT4sp7Mez3oQf-AxAzdBpEeTyCNF-7OchhA@mail.gmail.com>
	<12316.1552504492@sss.pgh.pa.us>
	<CA+TgmoacZD_WWWQ+_Fx93rGeSri=rzXO1SQ7XbW1BSns8DCh5Q@mail.gmail.com>
	<14279.1552508314@sss.pgh.pa.us>
	<036852f2-ba7f-7a1f-21c6-00bc3515eda3@lab.ntt.co.jp>
	<bac37617-9e25-becf-00f3-d9c1007b9983@lab.ntt.co.jp>
	<29436.1554731961@sss.pgh.pa.us>
	<CA+Tgmob=HVg+tvF5XyWW060K3XJsc-y1JdTOAVXk6zLGkHGQiQ@mail.gmail.com>

On Mon, Apr 08, 2019 at 10:40:41AM -0400, Robert Haas wrote:
> On Mon, Apr 8, 2019 at 9:59 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
>> Yeah, it's an open issue IMO.  I think we've been focusing on getting
>> as many feature patches done as we could during the CF, but now it's
>> time to start mopping up problems like this one.

Please note that it is registered as an older bug and not an open
item.

> Do you have any further thoughts based on my last response?

So your last response is that:
https://www.postgresql.org/message-id/CA+Tgmoa5rT+ZR+Vv+q1XLwQtDMCqkNL6B4PjR4V6YAC9K_LBxw@mail.gmail...
And what are you proposing as patch?  Perhaps something among those
lines?
https://www.postgresql.org/message-id/036852f2-ba7f-7a1f-21c6-00bc3515eda3@lab.ntt.co.jp

> Does anyone else wish to offer opinions?

It seems to me that Tom's argument to push in the way relcache
information is handled by copying its contents sounds sensible to me.
That's not perfect, but it is consistent with what exists (note
PublicationActions for a rather-still-not-much-complex example of
structure which gets copied from the relcache).
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190410064220.GD2728@paquier.xyz/2-signature.asc)
  download

view thread (71+ messages)  latest in thread

Message-ID: <20190410064220.GD2728@paquier.xyz>
Permalink:  ../20190410064220.GD2728@paquier.xyz/
Also on:    postgresql.org/message-id/20190410064220.GD2728@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: hyrax vs. RelationBuildPartitionDesc
  In-Reply-To: <20190410064220.GD2728@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox