From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_dump is broken for partition tablespaces
Date: Sun, 14 Apr 2019 13:32:14 -0400
Message-ID: <20190414173214.GA14838@alvherre.pgsql> (raw)
In-Reply-To: <20190414161029.ojfejg2lexv65m2b@alap3.anarazel.de>
On 2019-Apr-14, Andres Freund wrote:
> On 2019-04-14 10:38:05 -0400, Tom Lane wrote:
> > It's entirely possible BTW that this whole business of inheriting
> > tablespace from the partitioned table is broken and should be thrown
> > out. I certainly don't see any compelling reason for partitions to
> > act differently from regular tables in this respect, and the more
> > problems we find with the idea, the less attractive it seems.
>
> Indeed. After discovering during the tableam work, and trying to write
> tests for the equivalent feature for tableam, I decided that just not
> allowing AM specifications for partitioned tables is the right call - at
> least until the desired behaviour is clearer. The discussion of the last
> few days makes me think so even more.
To be honest, when doing that feature I neglected to pay attention to
(read: forgot about) default_tablespace, and it's mostly the
interactions with that feature that makes this partitioned table stuff
so complicated. I'm not 100% convinced yet that we need to throw it out
completely, but I'm less sure now about it than I was before.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_dump is broken for partition tablespaces
In-Reply-To: <20190414173214.GA14838@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox