agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Subject: Re: clean up docs for v12
Date: Fri, 19 Apr 2019 09:43:01 -0500
Message-ID: <20190419144301.GK2854@telsasoft.com> (raw)
In-Reply-To: <20190419080026.GJ2660@paquier.xyz>
References: <20190330224333.GQ5815@telsasoft.com>
	<20190408141828.GE10080@telsasoft.com>
	<20190419080026.GJ2660@paquier.xyz>

Thanks for committing those portions.

On Fri, Apr 19, 2019 at 05:00:26PM +0900, Michael Paquier wrote:
> I am particularly referring to patches 0005
> (publications use "a superuser" in error messages as well which could
> be fixed as well?),

I deliberately avoided changing thesee "errhint" messages, since the style
guide indicates that errhint should be a complete sentence.

pryzbyj@pryzbyj:~/src/postgres$ git grep 'must be a superuser' |grep errhint
src/backend/commands/event_trigger.c:                            errhint("The owner of an event trigger must be a superuser.")));
src/backend/commands/foreigncmds.c:                              errhint("The owner of a foreign-data wrapper must be a superuser.")));
src/backend/commands/publicationcmds.c:                                  errhint("The owner of a FOR ALL TABLES publication must be a superuser.")));
src/backend/commands/subscriptioncmds.c:                                 errhint("The owner of a subscription must be a superuser.")));

Justin

view thread (40+ messages)  latest in thread

Message-ID: <20190419144301.GK2854@telsasoft.com>
Permalink:  ../20190419144301.GK2854@telsasoft.com/
Also on:    postgresql.org/message-id/20190419144301.GK2854@telsasoft.com

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, michael@paquier.xyz
  Subject: Re: clean up docs for v12
  In-Reply-To: <20190419144301.GK2854@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox