From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: make \d pg_toast.foo show its indices
Date: Tue, 7 May 2019 11:16:00 -0400
Message-ID: <20190507151600.GH6197@tamriel.snowman.net> (raw)
In-Reply-To: <16689.1557158298@sss.pgh.pa.us>
References: <20190422154902.GH14223@telsasoft.com>
<CA+FpmFfihB-okuPa0sxyhALpXcxMuHJYDS95sqvra6+D5Zkk6g@mail.gmail.com>
<20190503142721.GC3925@telsasoft.com>
<CA+FpmFffNcyO8CcG7O7P72K4-PuzataxT=hfWbaV=SrosMK=Cg@mail.gmail.com>
<16689.1557158298@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Rafia Sabih <rafia.pghackers@gmail.com> writes:
> > On Fri, 3 May 2019 at 16:27, Justin Pryzby <pryzby@telsasoft.com> wrote:
> >> Thanks - what about also showing the associated non-toast table ?
>
> > IMHO, what makes more sense is to show the name of associated toast
> > table in the \dt+ of the normal table.
>
> I'm not for that: it's useless information in at least 99.44% of cases.
I don't think I'd put it in \dt+, but the toast table is still
pg_toast.pg_toast_{relOid}, right? What about showing the OID of the
table in the \d output, eg:
=> \d comments
Table "public.comments" (50788)
Column | Type | Collation | Nullable | Default
etc?
> Possibly it is useful in the other direction as Justin suggests.
> Not sure though --- generally, if you're looking at a specific
> toast table, you already know which table is its parent. But
> maybe confirmation is a good thing.
As mentioned elsewhere, there are certainly times when you don't know
that info and if you're looking at the definition of a TOAST table,
which isn't terribly complex, it seems like a good idea to go ahead and
include the table it's the TOAST table for.
> That seems off-topic for this thread though. I agree with the
> stated premise that \d on a toast table should show all the same
> information \d on a regular table would.
+1
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, rafia.pghackers@gmail.com, pryzby@telsasoft.com
Subject: Re: make \d pg_toast.foo show its indices
In-Reply-To: <20190507151600.GH6197@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox