From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Surafel Temesgen <surafel3000@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump multi VALUES INSERT
Date: Fri, 14 Jun 2019 18:27:29 -0400
Message-ID: <20190614222729.GA2080@alvherre.pgsql> (raw)
In-Reply-To: <alpine.DEB.2.21.1906141845560.19957@lancre>
On 2019-Jun-14, Fabien COELHO wrote:
>
> Hello Alvaro,
>
> > > Shouldn't the --rows-per-insert option also be available via pg_dumpall?
> > > All the other options for switching between COPY and INSERT are
> > > settable in pg_dumpall.
> >
> > Uh, yeah, absolutely.
> >
> > Surafel, are you in a position to provide a patch for that quickly?
>
> End of the week, more time, easy enough and I should have seen the issue
> while reviewing. Patch attached.
Hello Fabien
Thanks for producing a fix so quickly. David Rowley mentioned a couple
of issues OOB (stanzas were put in the wrong places, when considering
alphabetical ordering and such). It's pushed now.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, coelho@cri.ensmp.fr, peter.eisentraut@2ndquadrant.com, david.rowley@2ndquadrant.com, surafel3000@gmail.com, 9erthalion6@gmail.com
Subject: Re: pg_dump multi VALUES INSERT
In-Reply-To: <20190614222729.GA2080@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox