From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Kevin Grittner <kgrittn@gmail.com>
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
Date: Mon, 8 Jul 2019 16:57:40 +0900
Message-ID: <20190708075740.GF2709@paquier.xyz> (raw)
In-Reply-To: <CAOBaU_bX6u=dYiCk_SJPcxQR5LR4L5tieUq71FqPjf+nk_VbZQ@mail.gmail.com>
References: <20190701214648.GA9427@alvherre.pgsql>
<7140716c-679e-a0b9-a273-b201329d8891@2ndquadrant.com>
<CAOBaU_a-puHZ4pc0a4dMTnFShuU7jORmKFQN29RyzGomVj1CSQ@mail.gmail.com>
<abd97c36-b3a8-643e-7d25-2e54c74e78ea@2ndquadrant.com>
<CAOBaU_bX6u=dYiCk_SJPcxQR5LR4L5tieUq71FqPjf+nk_VbZQ@mail.gmail.com>
On Fri, Jul 05, 2019 at 07:25:41PM +0200, Julien Rouhaud wrote:
> On Fri, Jul 5, 2019 at 6:16 PM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>> Isn't that also the case for your proposal? We are not going to release
>> a new reindexdb before a new REINDEX.
>
> Sure, but my point was that once the new reindexdb is released (or if
> you're so desperate, using a nightly build or compiling your own), it
> can be used against any previous major version. There is probably a
> large fraction of users who don't perform a postgres upgrade when they
> upgrade their OS, so that's IMHO also something to consider.
I think that we need to think long-term here and be confident in the
fact we will still see breakages with collations and glibc, using a
solution that we think is the right API. Peter's idea to make the
backend-aware command of the filtering is cool. On top of that, there
is no need to add any conflict logic in reindexdb and we can live with
restricting --jobs support for non-index objects.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, rjuju123@gmail.com, peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, thomas.munro@gmail.com, daniel@manitou-mail.org, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, kgrittn@gmail.com
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
In-Reply-To: <20190708075740.GF2709@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox