From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: errbacktrace
Date: Mon, 8 Jul 2019 12:28:51 -0400
Message-ID: <20190708162851.GA11054@alvherre.pgsql> (raw)
In-Reply-To: <CA+q6zcViaQ-Lpgd3ELnZ-+UqDEL4SqWWLLCARHPSyd5nYageuQ@mail.gmail.com>
On 2019-Jul-08, Dmitry Dolgov wrote:
> > On Sat, Jun 29, 2019 at 7:41 AM Jaime Casanova <jaime.casanova@2ndquadrant.com> wrote:
> >
> > This is certainly a very useful thing. Sadly, it doesn't seem to compile when
> > trying to use libunwind.
>
> Yeah, the same for me. To make it works I've restricted libunwind to local
> unwinding only:
>
> #ifdef USE_LIBUNWIND
> #define UNW_LOCAL_ONLY
> #include <libunwind.h>
> #endif
Ah, yes. unwind's manpage says:
Normally, libunwind supports both local and remote unwinding (the latter will
be explained in the next section). However, if you tell libunwind that your
program only needs local unwinding, then a special implementation can be
selected which may run much faster than the generic implementation which
supports both kinds of unwinding. To select this optimized version, simply
define the macro UNW_LOCAL_ONLY before including the headerfile <libunwind.h>.
so I agree with unconditionally defining that symbol.
Nitpicking dept: I think in these tests:
+ if (!edata->backtrace &&
+ edata->funcname &&
+ backtrace_function[0] &&
+ strcmp(backtrace_function, edata->funcname) == 0)
+ set_backtrace(edata, 2);
we should test for backtrace_function[0] before edata->funcname, since
it seems more likely to be unset.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, 9erthalion6@gmail.com, thomas.munro@gmail.com, peter.eisentraut@2ndquadrant.com
Subject: Re: errbacktrace
In-Reply-To: <20190708162851.GA11054@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox