From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: noah@leadboat.com
Cc: pgsql-hackers@postgresql.org
Cc: 9erthalion6@gmail.com
Cc: andrew.dunstan@2ndquadrant.com
Cc: hlinnaka@iki.fi
Cc: robertmhaas@gmail.com
Cc: michael@paquier.xyz
Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
Date: Fri, 12 Jul 2019 17:30:41 +0900 (Tokyo Standard Time)
Message-ID: <20190712.173041.236938840.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <20190712010335.GB1610889@rfd.leadboat.com>
References: <20190523.161035.171704812.horiguchi.kyotaro@lab.ntt.co.jp>
<20190710.131914.109303138.horikyota.ntt@gmail.com>
<20190712010335.GB1610889@rfd.leadboat.com>
Many message seem lost during moving to new environmet..
I'm digging the archive but coudn't find the message for v15..
At Thu, 11 Jul 2019 18:03:35 -0700, Noah Misch <noah@leadboat.com> wrote in <20190712010335.GB1610889@rfd.leadboat.com>
> On Wed, Jul 10, 2019 at 01:19:14PM +0900, Kyotaro Horiguchi wrote:
> > Hello. Rebased the patch to master(bd56cd75d2).
>
> It looks like you did more than just a rebase, because this v16 no longer
> modifies many files that v14 did modify. (That's probably good, since you had
> pending review comments.) What other changes did you make?
Yeah.. Maybe I forgot to send pre-v15 or v16 before rebasing.
v14: WAL-logging is controled by AMs and syncing at commit is
controled according to the behavior. At-commit sync is still
controlled per-relation basis, which means it must be
processed before transaction state becomes TRNAS_COMMIT. So
it needs to be separated into PreCommit_RelationSync() from
AtEOXact_RelationCache().
v15: The biggest change is that at-commit sync is changed to smgr
basis. At-commit sync is programmed at creation of a storage
file (RelationCreateStorage), and smgrDoPendingDelete(or
smgrDoPendingOperations after rename) runs syncs. AM are no
longer involved and all permanent relations are WAL-skipped at
all in the creation transaction while wal_level=minimal.
All storages created for a relation are once synced then
removed at commit.
v16: rebased.
The v16 seems no longer works so I'll send further rebased version.
Sorry for the late reply and confusion..
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: horikyota.ntt@gmail.com, noah@leadboat.com, 9erthalion6@gmail.com, andrew.dunstan@2ndquadrant.com, hlinnaka@iki.fi, robertmhaas@gmail.com, michael@paquier.xyz
Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
In-Reply-To: <20190712.173041.236938840.horikyota.ntt@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox