From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Kevin Grittner <kgrittn@gmail.com>
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
Date: Mon, 22 Jul 2019 13:11:14 +0900
Message-ID: <20190722041114.GD1757@paquier.xyz> (raw)
In-Reply-To: <CAOBaU_Y+XxTVfZLA38gv9KHzPPwLrUhoc5Q1BunieLouyjCu7g@mail.gmail.com>
References: <20190712012007.GA2149@paquier.xyz>
<CAOBaU_bSU+7VR6U9h2dEGdJmL7GGv6+ZqHcw1tvQ_455Jyo=ng@mail.gmail.com>
<20190712055717.GK2149@paquier.xyz>
<CAOBaU_Y8Ts+TUX4Uf+5jqUKeZ-3zdxZQF9ZStr+x8gDmrxTZzQ@mail.gmail.com>
<CAOBaU_bHvyVPrm0UZNiJOmSCJ7p5DHZi9O+Q1pk8Gy-oRmY02A@mail.gmail.com>
<20190717075902.GA20614@paquier.xyz>
<CAOBaU_YdAfbrZD7hYX05YVz_OeOexweS6LFip8PZfqOQBwe8XQ@mail.gmail.com>
<20190718004514.GB1416@paquier.xyz>
<20190719003529.GB1859@paquier.xyz>
<CAOBaU_Y+XxTVfZLA38gv9KHzPPwLrUhoc5Q1BunieLouyjCu7g@mail.gmail.com>
On Fri, Jul 19, 2019 at 08:29:27AM +0200, Julien Rouhaud wrote:
> On Fri, Jul 19, 2019 at 2:35 AM Michael Paquier <michael@paquier.xyz> wrote:
>> For the second patch, could you send a rebase with a fix for the
>> connection slot when processing the reindex commands?
>
> Attached, I also hopefully removed all the now unneeded progname usage.
+ Note that this mode is not compatible the <option>-i / --index</option>
+ or the <option>-s / --system</option> options.
Nits: this is not a style consistent with the documentation. When
referring to both the long and short options the formulation "-i or
--index" gets used. Here we could just use the long option. This
sentence is missing a "with".
simple_string_list_append(&tables, optarg);
+ tbl_count++;
break;
The number of items in a simple list is not counted, and vacuumdb does
the same thing to count objects. What do you think about extending
simple lists to track the number of items stored?
+$node->issues_sql_like([qw(reindexdb -j2)],
+ qr/statement: REINDEX TABLE public.test1/,
+ 'Global and parallel reindex will issue per-table REINDEX');
Would it make sense to have some tests for schemas here?
One of my comments in [1] has not been answered. What about
the decomposition of a list of schemas into a list of tables when
using the parallel mode?
[1]: https://www.postgresql.org/message-id/20190711040433.GG4500@paquier.xyz
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, rjuju123@gmail.com, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, thomas.munro@gmail.com, daniel@manitou-mail.org, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, kgrittn@gmail.com
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
In-Reply-To: <20190722041114.GD1757@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox