From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Kevin Grittner <kgrittn@gmail.com>
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
Date: Mon, 22 Jul 2019 11:11:50 -0400
Message-ID: <20190722151150.GA22364@alvherre.pgsql> (raw)
In-Reply-To: <CAOBaU_YfksDTTbvwRKoMg_r6gh7i_T+gRYgAfdNym6BJODjsSQ@mail.gmail.com>
On 2019-Jul-22, Julien Rouhaud wrote:
> On Mon, Jul 22, 2019 at 6:11 AM Michael Paquier <michael@paquier.xyz> wrote:
> > simple_string_list_append(&tables, optarg);
> > + tbl_count++;
> > break;
> > The number of items in a simple list is not counted, and vacuumdb does
> > the same thing to count objects. What do you think about extending
> > simple lists to track the number of items stored?
>
> I considered this, but it would require to adapt all code that declare
> SimpleStringList stack variable (vacuumdb.c, clusterdb.c,
> createuser.c, pg_dumpall.c and pg_dump.c), so it looked like too much
> trouble to avoid 2 local variables here and 1 in vacuumdb.c. I don't
> have a strong opinion here, so I can go for it if you prefer.
Can we use List for this instead?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, rjuju123@gmail.com, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, thomas.munro@gmail.com, daniel@manitou-mail.org, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, kgrittn@gmail.com
Subject: Re: Add parallelism and glibc dependent only options to reindexdb
In-Reply-To: <20190722151150.GA22364@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox