From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unused header file inclusion
Date: Wed, 31 Jul 2019 16:36:07 -0400
Message-ID: <20190731203607.GA5260@alvherre.pgsql> (raw)
In-Reply-To: <20190731154451.yl6f47n4q3jyjg4r@alap3.anarazel.de>
On 2019-Jul-31, Andres Freund wrote:
> IDK, I find the compilation times annoying. And it's gotten quite
> noticably worse with all the speculative execution mitigations. Although
> to some degree that's not really the fault of individual compilations,
> but our buildsystem being pretty slow.
We're in a much better position now than a decade ago, in terms of clock
time. Back then I would resort to many tricks to avoid spurious
compiles, even manually touching some files to dates in the past to
avoid them. Nowadays I never bother with such things. But yes,
reducing the build time even more would be welcome for sure.
> * I think a lot of the interlinking stems from the bad idea to use
> typedef's everywhere. In contrast to structs they cannot be forward
> declared portably in our version of C. We should use a lot more struct
> forward declarations, and just not use the typedef.
I don't know about that ... I think the problem is that we both declare
the typedef *and* define the struct in the same place. If we were to
split those things to separate files, the required rebuilds would be
much less, I think, because changing a struct would no longer require
recompiles of files that merely pass those structs around (that's very
common for Node-derived structs). Forward-declaring structs in
unrelated header files just because they need them, feels a bit like
cheating to me.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, andres@anarazel.de, vignesh21@gmail.com
Subject: Re: Unused header file inclusion
In-Reply-To: <20190731203607.GA5260@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox