From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unused header file inclusion
Date: Mon, 5 Aug 2019 14:06:56 -0400
Message-ID: <20190805180656.GA11353@alvherre.pgsql> (raw)
In-Reply-To: <CALDaNm0SMDn4N8ewBoPL7cbVsbFDOEqumEUoUrmGoTt6__U-TQ@mail.gmail.com>
On 2019-Aug-04, vignesh C wrote:
> Made the fixes based on your comments, updated patch has the changes
> for the same.
Well, you fixed the two things that seem to me quoted as examples of
problems, but you didn't fix other occurrences of the same issues
elsewhere. For example, you remove lwlock.h from dsa.c but there are
structs there that have LWLocks as members. That's just the first hunk
of the patch; didn't look at the others but it wouldn't surprise that
they have similar issues. I suggest this patch should be rejected.
Then there's the <limits.h> removal, which is in tuplesort.c because of
INT_MAX as added by commit d26559dbf356 and still present ...
FWIW sharedtuplestore.c, a very young file, also includes <limits.h> but
that appears to be copy-paste of includes from some other file (and also
in an inappropriate place), so I have no objections to obliterating that
one. But other than that one line, this patch needs more "adult
supervision".
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, vignesh21@gmail.com, andres@anarazel.de
Subject: Re: Unused header file inclusion
In-Reply-To: <20190805180656.GA11353@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox