From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: remove "msg" parameter from convert_tuples_by_name
Date: Tue, 3 Sep 2019 21:42:14 -0400
Message-ID: <20190904014214.GA16504@alvherre.pgsql> (raw)
In-Reply-To: <CA+HiwqGOUzVLimAMOdebvYJJSDYJvPpPjnhwP56qXeWV2-zN3Q@mail.gmail.com>
On 2019-Sep-04, Amit Langote wrote:
> On Wed, Sep 4, 2019 at 3:52 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> >
> > On 2019-Aug-07, Amit Langote wrote:
> >
> > > If we're reducing the message string to occur only once in the source
> > > code, can we maybe write it to be more informative? I wonder if users
> > > aren't normally supposed to see this message?
> >
> > Grepping for the messages given to convert_tuples_by_position yields
> > quite a few matches in regression test output, but none for the one in
> > convert_tuples_by_name. This makes me think that it isn't user-visible,
> > unless things go very wrong.
> >
> > Pushed the patch, thanks.
>
> Thanks. I thought you'd change the ereport to elog while at it.
Oh, that didn't occur to me, but because it has errdetail and an errcode
it'd be more controversial. I don't see any reason to do it, frankly ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, amitlangote09@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: remove "msg" parameter from convert_tuples_by_name
In-Reply-To: <20190904014214.GA16504@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox