From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Amcheck: do rightlink verification with lock coupling
Date: Thu, 12 Sep 2019 10:16:12 -0300
Message-ID: <20190912131612.GA24926@alvherre.pgsql> (raw)
In-Reply-To: <0EB0CFA8-CBD8-4296-8049-A2C0F28FAE8C@yandex-team.ru>
On 2019-Sep-12, Andrey Borodin wrote:
> This patch violates one of amcheck design principles: current code
> does not ever take more than one page lock. I do not know: should we
> hold this rule or should we use more deep check?
The check does seem worthwhile to me.
As far as I know, in btree you can lock the right sibling of a page
while keeping lock on the page itself, without risk of deadlock. So I'm
not sure what's the issue with that. This is in the README:
In most cases we release our lock and pin on a page before attempting
to acquire pin and lock on the page we are moving to. In a few places
it is necessary to lock the next page before releasing the current one.
This is safe when moving right or up, but not when moving left or down
(else we'd create the possibility of deadlocks).
I suppose Peter was concerned about being able to run amcheck without
causing any trouble at all for concurrent operation; maybe we can retain
that property by making this check optional.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, x4mmm@yandex-team.ru
Subject: Re: Amcheck: do rightlink verification with lock coupling
In-Reply-To: <20190912131612.GA24926@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox