From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <hornschnorter@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: WIP: BRIN multi-range indexes
Date: Sat, 14 Sep 2019 19:30:49 +0200
Message-ID: <20190914173049.welhipsj7bijqahm@development> (raw)
In-Reply-To: <20190903220504.GA22557@alvherre.pgsql>
References: <20190611173052.eqdmtv272g2rpwfh@development>
<20190903220504.GA22557@alvherre.pgsql>
On Tue, Sep 03, 2019 at 06:05:04PM -0400, Alvaro Herrera wrote:
>On 2019-Jun-11, Tomas Vondra wrote:
>
>> Attached is this patch series, rebased on top of current master and the
>> opclass parameters patch [1]. I previously planned to keep those two
>> efforts separate for a while, but I decided to give it a try and the
>> breakage is fairly minor so I'll keep it this way - this patch has zero
>> chance of getting committed with the opclass parameters patch anyway.
>>
>> Aside from rebase and changes due to adopting opclass parameters, the
>> patch is otherwise unchanged.
>
>This patch series doesn't apply, but I'm leaving it alone since the
>brokenness is the opclass part, for which I have pinged the other
>thread.
>
Attached is an updated version of this patch series, rebased on top of
the opclass parameter patches, shared by Nikita a couple of days ago.
There's one extra fixup patch, addressing a bug in those patches.
Firstly, while I have some comments on the opclass parameters patches
(shared in the other thread), I think that patch series is moving in the
right direction. After rebase the code is somewhat simpler and easier to
read, which is good. I'm sure there's some more work needed on the APIs
and so on, but I'm optimistic about that.
The rest of this patch series (0007-0011) is mostly unchanged. I've
fixed a couple of bugs and added some comments (particularly to the
bloom opclass), but that's about it.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
[application/gzip] 0001-Introduce-opclass-parameters.patch.gz (21.0K, ../20190914173049.welhipsj7bijqahm@development/2-0001-Introduce-opclass-parameters.patch.gz)
download
[application/gzip] 0002-Introduce-amattoptions.patch.gz (1.9K, ../20190914173049.welhipsj7bijqahm@development/3-0002-Introduce-amattoptions.patch.gz)
download
[application/gzip] 0003-Use-amattoptions-in-contrib-bloom.patch.gz (2.7K, ../20190914173049.welhipsj7bijqahm@development/4-0003-Use-amattoptions-in-contrib-bloom.patch.gz)
download
[application/gzip] 0004-Use-opclass-parameters-in-GiST-tsvector_ops.patch.gz (7.1K, ../20190914173049.welhipsj7bijqahm@development/5-0004-Use-opclass-parameters-in-GiST-tsvector_ops.patch.gz)
download
[application/gzip] 0005-Remove-pg_index.indoption.patch.gz (11.1K, ../20190914173049.welhipsj7bijqahm@development/6-0005-Remove-pg_index.indoption.patch.gz)
download
[application/gzip] 0006-fix-amvalidate.patch.gz (556B, ../20190914173049.welhipsj7bijqahm@development/7-0006-fix-amvalidate.patch.gz)
download
[application/gzip] 0007-Pass-all-keys-to-BRIN-consistent-function-at-once.patch.gz (4.4K, ../20190914173049.welhipsj7bijqahm@development/8-0007-Pass-all-keys-to-BRIN-consistent-function-at-once.patch.gz)
download
[application/gzip] 0008-Move-IS-NOT-NULL-checks-to-bringetbitmap.patch.gz (2.7K, ../20190914173049.welhipsj7bijqahm@development/9-0008-Move-IS-NOT-NULL-checks-to-bringetbitmap.patch.gz)
download
[application/gzip] 0009-Move-processing-of-NULLs-from-BRIN-support-functions.patch.gz (4.5K, ../20190914173049.welhipsj7bijqahm@development/10-0009-Move-processing-of-NULLs-from-BRIN-support-functions.patch.gz)
download
[application/gzip] 0010-BRIN-bloom-indexes.patch.gz (21.8K, ../20190914173049.welhipsj7bijqahm@development/11-0010-BRIN-bloom-indexes.patch.gz)
download
[application/gzip] 0011-BRIN-multi-range-minmax-indexes.patch.gz (29.4K, ../20190914173049.welhipsj7bijqahm@development/12-0011-BRIN-multi-range-minmax-indexes.patch.gz)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, a.korotkov@postgrespro.ru, tgl@sss.pgh.pa.us, andres@anarazel.de, hornschnorter@gmail.com
Subject: Re: WIP: BRIN multi-range indexes
In-Reply-To: <20190914173049.welhipsj7bijqahm@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox