From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Abhijit Menon-Sen <ams@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Date: Mon, 16 Sep 2019 11:11:06 -0300
Message-ID: <20190916141106.GA10690@alvherre.pgsql> (raw)
In-Reply-To: <20190916134056.GB6026@paquier.xyz>
On 2019-Sep-16, Michael Paquier wrote:
> On Mon, Sep 16, 2019 at 11:46:16AM +0530, Amit Kapila wrote:
> > I don't see much use of separating information for infomask and infomask2.
>
> Okay, using two separate columns leads to the attached. Any thoughts?
> This also includes a fix for cases with IS_LOCKED_ONLY and UPGRADED.
I like how it looks in the expected test output. Didn't review the code
closely, but it looks reasonable in a quick glance.
Whitespace nitpick: pgindent will do something very annoying with this:
> + PG_RETURN_DATUM(
> + HeapTupleGetDatum(heap_form_tuple(tupdesc, values, nulls)));
I suggest to split the line in the first comma, not in the parens.
> + Combined flags include for example <literal>HEAP_XMIN_FROZEN</literal>
> + which is defined as a set of <literal>HEAP_XMIN_COMMITTED</literal>
> + and <literal>HEAP_XMIN_INVALID</literal>.
I suggest something like "Combined flags are displayed for source-level
macros that take into account the value of more than one raw bit, such
as HEAP_XMIN_FROZEN". (We probably don't want an exhaustive list, which
becomes annoying to maintain; users can refer to the source file.)
There's a typo "bites" in a comment.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, amit.kapila16@gmail.com, sawada.mshk@gmail.com, craig@2ndquadrant.com, ashu.coek88@gmail.com, rjuju123@gmail.com, pg@bowt.ie, ams@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, pavan.deolasee@2ndquadrant.com
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
In-Reply-To: <20190916141106.GA10690@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox