From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Paul Guo <pguo@pivotal.io>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Jimmy Yih <jyih@pivotal.io>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>
Cc: Alexey Kondratov <a.kondratov@postgrespro.ru>
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
Date: Wed, 25 Sep 2019 14:48:12 -0300
Message-ID: <20190925174812.GA4916@alvherre.pgsql> (raw)
In-Reply-To: <CAEET0ZGtybm-CsXkwQgtvryhRu4L258g3ECgeuAwWt=5a2dS_Q@mail.gmail.com>
CC Alexey for reasons that become clear below.
On 2019-Sep-25, Paul Guo wrote:
> > Question about 0003. If we specify --skip-clean-shutdown and the cluter
> > was not cleanly shut down, shouldn't we error out instead of trying to
> > press on?
>
> pg_rewind would error out in this case, see sanityChecks().
> Users are expected to clean up themselves if they use this argument.
Ah, good. We should have a comment about that below the relevant
stanza, I suggest. (Or maybe in the same comment that ends in line
272).
I pushed 0001 with a few tweaks. Nothing really substantial, just my
OCD that doesn't leave me alone ... but this means your subsequent
patches need to be adjusted. One thing is that that patch touched
pg_rewind for no reason (those changes should have been in 0002) --
dropped those.
Another thing in 0002 is that you're adding a "-R" switch to pg_rewind,
but we have another patch in the commitfest using the same switch for a
different purpose. Maybe you guys need to get to an agreement over who
uses the letter :-) Also, it would be super helpful if you review
Alexey's patch: https://commitfest.postgresql.org/24/1849/
This line is far too long:
+ printf(_(" -s, --skip-clean-shutdown skip running single-mode postgres if needed to make sure target is clean shutdown\n"));
Can we make the description more concise?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, pguo@pivotal.io, michael@paquier.xyz, thomas.munro@gmail.com, jyih@pivotal.io, aagrawal@pivotal.io, a.kondratov@postgrespro.ru
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
In-Reply-To: <20190925174812.GA4916@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox