agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: thomas.munro@gmail.com
Cc: tomas.vondra@2ndquadrant.com
Cc: andres@anarazel.de
Cc: a.zakirov@postgrespro.ru
Cc: ah@cybertec.at
Cc: magnus@hagander.net
Cc: robertmhaas@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@postgresql.org
Subject: Re: shared-memory based stats collector
Date: Wed, 25 Sep 2019 18:01:02 -0300
Message-ID: <20190925210102.GA26396@alvherre.pgsql> (raw)
In-Reply-To: <20190910.175858.267726221.horikyota.ntt@gmail.com>
On 2019-Sep-10, Kyotaro Horiguchi wrote:
> At Tue, 3 Sep 2019 18:28:05 -0400, Alvaro Herrera <alvherre@2ndquadrant.com> wrote in <20190903222805.GA13932@alvherre.pgsql>
> > > Found a bug in initialization. StatsShememInit() was placed at a
> > > wrong place and stats code on child processes accessed
> > > uninitialized pointer. It is a leftover from the previous shape
> > > where dsm was activated on postmaster.
> >
> > This doesn't apply anymore. Can you please rebase?
>
> Thanks! I forgot to post rebased version after doing. Here it is.
>
> - (Re)Rebased to the current master.
> - Passed all tests for me.
This seems to have very trivial conflicts -- please rebase again?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
view thread (238+ messages) latest in thread
Message-ID: <20190925210102.GA26396@alvherre.pgsql>
Permalink: ../20190925210102.GA26396@alvherre.pgsql/
Also on: postgresql.org/message-id/20190925210102.GA26396@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, horikyota.ntt@gmail.com, thomas.munro@gmail.com, tomas.vondra@2ndquadrant.com, andres@anarazel.de, a.zakirov@postgrespro.ru, ah@cybertec.at, magnus@hagander.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: shared-memory based stats collector
In-Reply-To: <20190925210102.GA26396@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox