From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Paul Guo <pguo@pivotal.io>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Jimmy Yih <jyih@pivotal.io>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>
Cc: Alexey Kondratov <a.kondratov@postgrespro.ru>
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
Date: Thu, 26 Sep 2019 11:51:54 -0300
Message-ID: <20190926145154.GA22406@alvherre.pgsql> (raw)
In-Reply-To: <CAEET0ZHdPgZmvcu18yNtVwqYqTo1kKs=9WVHyZXyU9g9pp1T9Q@mail.gmail.com>
> Thanks. I've updated the reset two patches and attached as v8.
Great, thanks.
> Note in the 2nd patch, the long option is changed as below. Both the option
> and description
> now seems to be more concise since we want db state as either DB_SHUTDOWNED
> or
> DB_SHUTDOWNED_IN_RECOVERY.
>
> "-s, --no-ensure-shutdowned do not auto-fix unclean shutdown"
Note that "shutdowned" is incorrect English; we've let
it live in the code because it's not user-visible, but we should
certainly not immortalize it where it becomes so. I suppose
"--no-ensure-shutdown" is okay, although I think some may prefer
"--no-ensure-shut-down". Opinions from native speakers would be
welcome. Also, let's expand "auto-fix" to "automatically fix" (or
"repair" if there's room in the line? Not sure. Can be bikeshedded to
death I guess.)
Secondarily, I see no reason to test connstr_source rather than just
"conn" in the other patch; doing it the other way is more natural, since
it's that thing that's tested as an argument.
pg_rewind.c: Please put the new #include line keeping the alphabetical
order.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, pguo@pivotal.io, michael@paquier.xyz, thomas.munro@gmail.com, jyih@pivotal.io, aagrawal@pivotal.io, a.kondratov@postgrespro.ru
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
In-Reply-To: <20190926145154.GA22406@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox