From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: errbacktrace
Date: Fri, 27 Sep 2019 12:50:01 -0300
Message-ID: <20190927155001.GA24199@alvherre.pgsql> (raw)
In-Reply-To: <20190913155432.GA1200@alvherre.pgsql>
On 2019-Sep-13, Alvaro Herrera wrote:
> On 2019-Aug-20, Peter Eisentraut wrote:
>
> > The memory management of that seems too complicated. The "extra"
> > mechanism of the check/assign hooks only supports one level of malloc.
> > Using a List seems impossible. I don't know if you can safely do a
> > malloc-ed array of malloc-ed strings either.
>
> Here's an idea -- have the check/assign hooks create a different
> representation, which is a single guc_malloc'ed chunk that is made up of
> every function name listed in the GUC, separated by \0. That can be
> scanned at error time comparing the function name with each piece.
Peter, would you like me to clean this up for commit, or do you prefer
to keep authorship and get it done yourself?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, 9erthalion6@gmail.com, thomas.munro@gmail.com
Subject: Re: errbacktrace
In-Reply-To: <20190927155001.GA24199@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox