From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Online checksums patch - once again
Date: Mon, 30 Sep 2019 14:49:44 +0200
Message-ID: <20190930124944.vn2c2y44ybxck6wa@development> (raw)
In-Reply-To: <CABUevEyTp8OKUxV+-id0PLoB0sA+7d2uefAzYnq=Kb03V5r5PQ@mail.gmail.com>
References: <CABUevEwE3urLtwxxqdgd5O2oQz9J717ZzMbh+ziCSa5YLLU_BA@mail.gmail.com>
<20190926194828.GA17211@alvherre.pgsql>
<CABUevEyTp8OKUxV+-id0PLoB0sA+7d2uefAzYnq=Kb03V5r5PQ@mail.gmail.com>
On Mon, Sep 30, 2019 at 01:03:20PM +0200, Magnus Hagander wrote:
>On Thu, Sep 26, 2019 at 9:48 PM Alvaro Herrera <alvherre@2ndquadrant.com>
>wrote:
>
>> On 2019-Aug-26, Magnus Hagander wrote:
>>
>> > OK, let's try this again :)
>> >
>> > This is work mainly based in the first version of the online checksums
>> > patch, but based on top of Andres WIP patchset for global barriers (
>> >
>> https://www.postgresql.org/message-id/20181030051643.elbxjww5jjgnjaxg%40alap3.anarazel.de
>> > )
>> >
>> > Andres patch has been enhanced with wait events per
>> >
>> https://www.postgresql.org/message-id/CABUevEwy4LUFqePC5YzanwtzyDDpYvgrj6R5WNznwrO5ouVg1w%40mail.gma...
>> > .
>>
>> Travis says your SGML doesn't compile (maybe you just forgot to "git
>> add" and edit allfiles.sgml?):
>>
>
>Nope, even easier -- the reference pgVerifyChecksums was renamed to
>pgChecksums and for some reason we missed that in the merge.
>
>I've rebased again on top of todays master, but that was the only change I
>had to make.
>
>
>Other than bots, this patch doesn't seem to have attracted any reviewers
>> this time around. Perhaps you need to bribe someone? (Maybe "how sad
>> your committer SSH key stopped working" would do?)
>>
>
>Hmm. I don't think that's a bribe, that's a threat. However, maybe it will
>work.
>
IMHO the patch is ready to go - I think the global barrier solves the
issue in the previous version, and that's the only problem I'm aware of.
So +1 from me to go ahead and push it.
And now please uncomment my commit SSH key again, please ;-)
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, magnus@hagander.net, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, daniel@yesql.se
Subject: Re: Online checksums patch - once again
In-Reply-To: <20190930124944.vn2c2y44ybxck6wa@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox