pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Binguo Bao <djydewang@gmail.com>
Cc: Paul Ramsey <pramsey@cleverelephant.ca>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Optimize partial TOAST decompression
Date: Tue, 1 Oct 2019 16:57:58 +0200
Message-ID: <20191001145758.rofbwvguwxwpdxyb@development> (raw)
In-Reply-To: <4411.1569939037@sss.pgh.pa.us>
References: <20190925203834.GA25060@alvherre.pgsql>
	<20190926230036.ubxzgkqsphbzmbdl@development>
	<20190930155607.5tnyzksijgm4imbg@development>
	<E11354D1-6980-408D-AC4B-E147EB7CCDED@yandex-team.ru>
	<20190930172951.gdedvexnf4d2wv5e@development>
	<123EF56B-F8EC-4868-B49B-095795095E7A@yandex-team.ru>
	<20191001100805.wnnuj73kuzfwzs56@development>
	<20191001123420.uwzxtqr7qvleyxef@development>
	<20191001131803.j6uin7nho7t6vxzy@development>
	<4411.1569939037@sss.pgh.pa.us>

On Tue, Oct 01, 2019 at 10:10:37AM -0400, Tom Lane wrote:
>Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>> Hmmm, this seems to trigger a failure on thorntail, which is a sparc64
>> machine (and it seems to pass on all x86 machines, so far).
>
>gharial's not happy either, and I bet if you wait a bit longer you'll
>see the same on other big-endian machines.
>
>> I wonder if that's wrong, somehow ... Maybe it should use VARSIZE_ANY,
>> but then how would it work on any platform and only fail on sparc64?
>
>Maybe it accidentally seems to work on little-endian, thanks to the
>different definitions of varlena headers?
>

Maybe. Let's see if just using VARSIZE_ANY does the trick. If not, I'll
investigate further.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (32+ messages)  latest in thread

Message-ID: <20191001145758.rofbwvguwxwpdxyb@development>
Permalink:  ../20191001145758.rofbwvguwxwpdxyb@development/
Also on:    postgresql.org/message-id/20191001145758.rofbwvguwxwpdxyb@development

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, tgl@sss.pgh.pa.us, x4mmm@yandex-team.ru, alvherre@2ndquadrant.com, djydewang@gmail.com, pramsey@cleverelephant.ca
  Subject: Re: Optimize partial TOAST decompression
  In-Reply-To: <20191001145758.rofbwvguwxwpdxyb@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox