agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Christoph Berg <myon@debian.org>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Douglas Doole <dougdoole@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Collation versioning
Date: Fri, 8 Nov 2019 10:20:03 +0100
Message-ID: <20191108092003.GA8017@msg.df7cb.de> (raw)
In-Reply-To: <3c3b9ff84d21acf3188558928249d04db84ea2e9.camel@cybertec.at>
References: <b65e3840-f8b7-b266-72d3-4b911512d0b1@2ndquadrant.com>
<CA+hUKGLaR8zXhXhirNG5aT2EQP8ARFimHFai7iUgdYz_jNkocw@mail.gmail.com>
<CAOBaU_b9V502Mw2x0_+=-GT_Q26bdsuiA=8ZzqRhd_4Gi3G5aQ@mail.gmail.com>
<CA+hUKGKOEu0BSURXFG=uREu1yjRXEfNj7yYmAgp-OmZm6H-Zxg@mail.gmail.com>
<CAOBaU_Zm7J6Jd_Bw9oFz5JMdFWY5fX_oD9qPQ1qRhXj-wzrS3Q@mail.gmail.com>
<CAOBaU_aL=4f67L+m2s28DmiaacZ=Dn75BZY-HGmEq1WquGa-Jg@mail.gmail.com>
<CA+hUKGKi=Vjj0J1tk9=JbKOFqR7Ot4WcRdp7gkzam-JFJF0Agg@mail.gmail.com>
<20191108013654.GA1768@paquier.xyz>
<CA+hUKGKa_ZKbWVLwH_O0MvLQMHRjTpHOR-9Y_7XCm-OpXLVkcQ@mail.gmail.com>
<3c3b9ff84d21acf3188558928249d04db84ea2e9.camel@cybertec.at>
Re: Laurenz Albe 2019-11-08 <camel@cybertec.at/">3c3b9ff84d21acf3188558928249d04db84ea2e9.camel@cybertec.at>
> #3 is the best proposal, but there is still the need to run
> ALTER INDEX on all affected indexes to keep PostgreSQL from nagging.
> Perhaps the situation could be improved with a pg_upgrade option
> --i-know-my-indexes-are-fine that causes a result like #2.
> Together with a bold note in the release notes, this may relieve
> the pain.
Ack.
We should also try to make the actual commands more accessible.
Instead of having the user specify a version number we could as well
determine from the current state of the system as in
ALTER INDEX ... DEPENDS ON 'version-number-I-never-heard-of-before'
could it just be
ALTER INDEX ... COLLATION IS CURRENT
or, given the general action to take is reindexing, how about a no-op reindex?
REINDEX INDEX ... METADATA ONLY
That might look less scary to the average end user.
Do we even think people upgrade PG and the OS at the same time?
pg_upgrade might frequently actually be invoked on an otherwise
unchanged system, so we could even make "collations are fine" the
default for pg_upgrade. And maybe have a switch like pg_upgrade --os-upgrade
that reverses this.
Christoph
view thread (188+ messages) latest in thread
Message-ID: <20191108092003.GA8017@msg.df7cb.de>
Permalink: ../20191108092003.GA8017@msg.df7cb.de/
Also on: postgresql.org/message-id/20191108092003.GA8017@msg.df7cb.de
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: myon@debian.org, laurenz.albe@cybertec.at, thomas.munro@gmail.com, michael@paquier.xyz, rjuju123@gmail.com, peter.eisentraut@2ndquadrant.com, dougdoole@gmail.com
Subject: Re: Collation versioning
In-Reply-To: <20191108092003.GA8017@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox