pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Monitoring disk space from within the server
Date: Fri, 8 Nov 2019 14:58:30 +0100
Message-ID: <20191108135830.GJ8017@msg.df7cb.de> (raw)
In-Reply-To: <CAOBaU_Zu6RP6-mHyA_J9-xkxJe0tarTVqU9TFza+tCPKUxsjiA@mail.gmail.com>
References: <20191108132419.GG8017@msg.df7cb.de>
	<CAOBaU_YVGEnsnP1ufp42NiJ+WvPHRWBOsBOcaxWxsbXPN_sdNQ@mail.gmail.com>
	<20191108133531.GH8017@msg.df7cb.de>
	<CAOBaU_Zu6RP6-mHyA_J9-xkxJe0tarTVqU9TFza+tCPKUxsjiA@mail.gmail.com>

Re: Julien Rouhaud 2019-11-08 <CAOBaU_Zu6RP6-mHyA_J9-xkxJe0tarTVqU9TFza+tCPKUxsjiA@mail.gmail.com>
> The related function on Windows is apparently GetDiskFreeSpaceA [1].

There's a link to GetDiskFreeSpaceExA() which seems much easier to use
because it accepts any directory on the drive in question:

https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskfreespaceexa

> It'll probably be quite hard to get something consistent for most of
> counters, so probably pg_tablespace_(disk_)space is the best name,
> providing only total size and free size?

So, how about:

pg_tablespace_disk_space -> total_bytes | free_bytes

The inode numbers are probably not very interesting in a PG tablespace
as we don't create that many files. Or do we think including these
counters (on UNIX) makes sense?

There's precedents for leaving fields NULL where not supported by the
OS, for example pg_stat_file() returns "change" on UNIX only, and
"creation" on Windows only.

Christoph





view thread (22+ messages)  latest in thread

Message-ID: <20191108135830.GJ8017@msg.df7cb.de>
Permalink:  ../20191108135830.GJ8017@msg.df7cb.de/
Also on:    postgresql.org/message-id/20191108135830.GJ8017@msg.df7cb.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: myon@debian.org, rjuju123@gmail.com
  Subject: Re: Monitoring disk space from within the server
  In-Reply-To: <20191108135830.GJ8017@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox