From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org, Daniel Gustafsson <daniel@yesql.se>
Subject: Re: format of pg_upgrade loadable_libraries warning
Date: Thu, 14 Nov 2019 17:16:41 -0500
Message-ID: <20191114221641.GD6160@momjian.us> (raw)
In-Reply-To: <20191114190652.GA23586@alvherre.pgsql>
References: <20191007174757.GE4732@momjian.us>
<20191114190652.GA23586@alvherre.pgsql>
On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote:
> BTW, how is one supposed to "manually upgrade databases that use
> contrib/isb"? This part is not very clear.
I thought you would dump out databases that use isn, drop those
databases, use pg_upgrade for the remaining databases, then load the
dumped database. Attached is a patch that improves the wording.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Attachments:
[text/x-diff] isn.diff (966B, ../20191114221641.GD6160@momjian.us/2-isn.diff)
download | inline diff:diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.cindex ff7057db73..e5f1c64799 100644--- a/src/bin/pg_upgrade/check.c+++ b/src/bin/pg_upgrade/check.c@@ -887,9 +887,9 @@ check_for_isn_and_int8_passing_mismatch(ClusterInfo *cluster)
pg_fatal("Your installation contains \"contrib/isn\" functions which rely on the\n"
"bigint data type. Your old and new clusters pass bigint values\n"
"differently so this cluster cannot currently be upgraded. You can\n"
- "manually upgrade databases that use \"contrib/isn\" facilities and remove\n"- "\"contrib/isn\" from the old cluster and restart the upgrade. A list of\n"- "the problem functions is in the file:\n"+ "manually dump databases that use \"contrib/isn\" facilities in the old\n"+ "cluster, drop them, restart the upgrade, and restore them laster. A\n"+ "list of the problem functions is in the file:\n"
" %s\n\n", output_path);
}
else
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, daniel@yesql.se
Subject: Re: format of pg_upgrade loadable_libraries warning
In-Reply-To: <20191114221641.GD6160@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox