From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Date: Wed, 20 Nov 2019 10:54:11 -0300
Message-ID: <20191120135411.GA10316@alvherre.pgsql> (raw)
In-Reply-To: <CAC+AXB1p5Dnysu269WUEdK6maYY1CLXA1FC_u+Jm1YBkip2Jbg@mail.gmail.com>
On 2019-Nov-20, Juan José Santamaría Flecha wrote:
> I was not able to reproduce the Permission denied error with current HEAD,
> until I opened another CMD inside the "pg_replslot/regression_slot" folder.
> This will be problematic, is the deletion of the folder actually needed?
Yes :-( The code assumes that if the directory is there, then it's
valid. Trying to remove that assumption is probably a more invasive
fix.
I think ReplicationSlotDropAcquired is too pessimistic (no recourse if
the rename fails) and too optimistic (this will almost never happen).
We could change it so that the rename is retried a few times, and avoid
the failure. (Naturally, the rmtree should also be retried.) The code
seems written with the POSIX semantics in mind, but it seems easy to
improve.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, juanjo.santamaria@gmail.com, amitdkhan.pg@gmail.com, amit.kapila16@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, robertmhaas@gmail.com, tomas.vondra@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
In-Reply-To: <20191120135411.GA10316@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox