From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Gasper Zejn <zejn@owca.info>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pglz performance
Date: Thu, 28 Nov 2019 23:43:56 +0100
Message-ID: <20191128224356.4oca4lijnpnqctqa@development> (raw)
In-Reply-To: <8664A3B8-C049-45F5-9981-0E11BB619EE7@yandex-team.ru>
References: <20191101154828.GA15829@alvherre.pgsql>
<20191101165950.b5azncggaqfan5fi@development>
<35c2a448-06b8-eab0-05ea-34a3f51ba9a8@2ndquadrant.com>
<20191125080309.GK99720@paquier.xyz>
<13C6049A-C3D9-4021-9934-41488DE38BE9@yandex-team.ru>
<20191125082940.GP99720@paquier.xyz>
<20191126094324.7y2n3n3houetavwd@development>
<51E4C9A3-E2A3-4122-B5BC-B6A70BA64253@yandex-team.ru>
<20191127152818.ojgfrxfzr7pqkpic@development>
<8664A3B8-C049-45F5-9981-0E11BB619EE7@yandex-team.ru>
On Wed, Nov 27, 2019 at 11:27:49PM +0500, Andrey Borodin wrote:
>
>
>> 27 нояб. 2019 г., в 20:28, Tomas Vondra <tomas.vondra@2ndquadrant.com> написал(а):
>>
>>>>
>>>> 6) I'm pretty sure the comment in the 'while (off < len)' branch will be
>>>> badly mangled by pgindent.
>>>
>>> I think I can just write it without line limit and then run pgindent.
>>> Will try to do it this evening. Also, I will try to write more about
>>> memmove.
>Well, yes, I could not make pgindent format some parts of that comment, gave up and left only simple text.
>>>
>>>>
>>>> 7) The last change moving "copy" to the next line seems unnecessary.
>>>
>>> Oh, looks like I had been rewording this comment, and eventually came
>>> to the same text..Yes, this change is absolutely unnecessary.
>>>
>>> Thanks!
>>>
>>
>> Good. I'll wait for an updated version of the patch and then try to get
>> it pushed by the end of the CF.
>
OK, pushed, with some minor cosmetic tweaks on the comments (essentially
using the formatting trick pointed out by Alvaro), and removing one
unnecessary change in pglz_maximum_compressed_size.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, x4mmm@yandex-team.ru, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, zejn@owca.info, pgsql-hackers@lists.postgresql.org
Subject: Re: pglz performance
In-Reply-To: <20191128224356.4oca4lijnpnqctqa@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox