From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Subject: Re: segmentation fault when cassert enabled
Date: Mon, 16 Dec 2019 16:46:39 +0100
Message-ID: <20191216164639.4b29efd4@firost> (raw)
In-Reply-To: <32a64f45-6c01-d2bf-d90a-49ff4bfedcfb@2ndquadrant.com>
References: <20191025175929.7e90dbf5@firost>
<18714.1572020918@sss.pgh.pa.us>
<20191105172918.3e32a446@firost>
<c75077cd-a1a7-9a2d-5dc6-4d3d8acfaafa@2ndquadrant.com>
<20191125155519.5338e3c9@firost>
<CAA4eK1+9vQb34faKLJbY6KD62HZOJ5Jm9PzoZGiK_9J7cvyDdw@mail.gmail.com>
<CALDaNm0kVT3+ku99M6=Wy9X=3=-H8jp_Yt7WVuTraPuREZugxQ@mail.gmail.com>
<CAA4eK1LGNKWDBQ7ktxfQ6vL=f8t_05b_4pSch4Hr=CNj-S-a7Q@mail.gmail.com>
<32a64f45-6c01-d2bf-d90a-49ff4bfedcfb@2ndquadrant.com>
On Mon, 16 Dec 2019 13:27:43 +0100
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
> On 2019-12-16 11:11, Amit Kapila wrote:
> > I agree that this is a timing issue. I also don't see a way to write
> > a reproducible test for this. However, I could reproduce it via
> > debugger consistently by following the below steps. I have updated a
> > few comments and commit messages in the attached patch.
> >
> > Peter E., Petr J or anyone else, do you have comments or objections on
> > this patch? If none, then I am planning to commit (and backpatch)
> > this patch in a few days time.
>
> The patch seems fine to me. Writing a test seems hard. Let's skip it.
>
> The commit message has a duplicate "building"/"built" in the first sentence.
I think the sentence is quite long. I had to re-read it to get it.
What about:
This patch allows building the local relmap cache for a subscribed relation
after processing pending invalidation messages and potential relcache
updates.
Regards,
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jgdr@dalibo.com, peter.eisentraut@2ndquadrant.com, amit.kapila16@gmail.com, vignesh21@gmail.com, petr.jelinek@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, pg@bowt.ie
Subject: Re: segmentation fault when cassert enabled
In-Reply-To: <20191216164639.4b29efd4@firost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox