From: Justin Pryzby <pryzby@telsasoft.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: pgsql-performance@postgresql.org
Subject: Re: distinguish index cost component from table component
Date: Fri, 3 Jan 2020 10:03:15 -0600
Message-ID: <20200103160315.GL12066@telsasoft.com> (raw)
In-Reply-To: <CAMkU=1xcf-igvHSrta+gnTgE+K+Cnc-F=7z8G6YJTHwNSCyP1Q@mail.gmail.com>
References: <20200103141427.GK12066@telsasoft.com>
<CAMkU=1xcf-igvHSrta+gnTgE+K+Cnc-F=7z8G6YJTHwNSCyP1Q@mail.gmail.com>
On Fri, Jan 03, 2020 at 09:33:35AM -0500, Jeff Janes wrote:
> Of course this doesn't really answer your question, as the
> separately-reported costs of a bitmap heap and bitmap index scan are
> unlikely to match what the costs would be of a regular index scan, if they
> were reported separately.
I think the cost of index component of bitmap scan would be exactly the same
as the cost of the original indexscan.
>> Or maybe explain should report it.
>
> I wouldn't be optimistic about getting such a backwards-incompatible change
> accepted (plus it would surely add some small accounting overhead, which
> again would probably not be acceptable). But if you do enough tuning work,
> perhaps it would be worth carrying an out-of-tree patch to implement that.
> I wouldn't be so interested in writing such a patch, but would be
> interested in using one were it available somewhere.
I did the attached in the simplest possible way. If it's somehow possible get
the path's index_total_cost from the plan, then there'd be no additional
overhead.
Justin
Attachments:v1-0001-explain-show-index_total_cost.patch (text/x-diff, 1.9K) download
From 52ac676bdef1aa0a1fa18520a69d267fbb93eb19 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Fri, 3 Jan 2020 09:53:31 -0600
Subject: [PATCH v1] explain: show index_total_cost
---
src/backend/commands/explain.c | 3 +++
src/backend/optimizer/plan/createplan.c | 1 +
src/include/nodes/plannodes.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.cindex 0910d91..8973c86 100644--- a/src/backend/commands/explain.c+++ b/src/backend/commands/explain.c@@ -1614,6 +1614,9 @@ ExplainNode(PlanState *planstate, List *ancestors,
if (plan->qual)
show_instrumentation_count("Rows Removed by Filter", 1,
planstate, es);
+ if (es->costs && es->verbose) // && verbose ?+ ExplainPropertyFloat("Index Total Cost", NULL,+ planstate->plan->indextotalcost, 2, es);
break;
case T_IndexOnlyScan:
show_scan_qual(((IndexOnlyScan *) plan)->indexqual,
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.cindex dff826a..c0419bc 100644--- a/src/backend/optimizer/plan/createplan.c+++ b/src/backend/optimizer/plan/createplan.c@@ -2924,6 +2924,7 @@ create_indexscan_plan(PlannerInfo *root,
best_path->indexscandir);
copy_generic_path_info(&scan_plan->plan, &best_path->path);
+ ((Plan *)scan_plan)->indextotalcost = best_path->indextotalcost;
return scan_plan;
}
diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.hindex 32c0d87..711c9d8 100644--- a/src/include/nodes/plannodes.h+++ b/src/include/nodes/plannodes.h@@ -122,6 +122,7 @@ typedef struct Plan
*/
Cost startup_cost; /* cost expended before fetching any tuples */
Cost total_cost; /* total cost (assuming all tuples fetched) */
+ Cost indextotalcost; /* total cost of index */
/*
* planner's estimate of result size of this plan step
--
2.7.4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, jeff.janes@gmail.com, pgsql-performance@postgresql.org
Subject: Re: distinguish index cost component from table component
In-Reply-To: <20200103160315.GL12066@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox