pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Dmitry Belyavsky <beldmit@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: Ltree syntax improvement
Date: Mon, 6 Jan 2020 14:49:33 +0100
Message-ID: <20200106134933.u2rblkj7ec4jky6u@development> (raw)
In-Reply-To: <CA+hUKGLMS_bjeT1T7g5wT+rJQb8EUcW0HDtUbCueXTmBJ9Z9UA@mail.gmail.com>
References: <CADqLbzLS1dy9TARVBYR=E+HUwjrAqZAoakFp_vTKWFJK=XF3Rg@mail.gmail.com>
	<20190708203303.GA17993@alvherre.pgsql>
	<CADqLbzKZ0jEEiV2mvFs3LfjfghGX9-goybbFVgUNGyqDu=rg4w@mail.gmail.com>
	<CA+hUKG+G7fP-t43ptqkBw9aW2zQuazN2g_U9yCX6dN9E65u4tw@mail.gmail.com>
	<CADqLbzKCh2e-nOyAtCX4GqW+HbwD4yX=wuOMMRFGtRYWgcnMeg@mail.gmail.com>
	<f2aa520a-f987-e03d-33cc-8aac52511332@postgrespro.ru>
	<CA+hUKGLMS_bjeT1T7g5wT+rJQb8EUcW0HDtUbCueXTmBJ9Z9UA@mail.gmail.com>

Hi,

This patch got mostly ignored since 2019-07 commitfest :-( The latest
patch (sent by Nikita) does not apply because of a minor conflict in
contrib/ltree/ltxtquery_io.c.

I see the patch removes a small bit of ltree_plpython tests which would
otherwise fail (with the "I don't know plpython" justification). Why not
to instead update the tests to accept the new output? Or is it really
the case that the case that we no longer need those tests?

The patch also reworks some parts from "if" to "switch" statements. I
agree switch statements are more readable, but maybe we should do this
in two steps - first adopting the "switch" without changing the logic,
and then making changes. But maybe that's an overkill.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (33+ messages)  latest in thread

Message-ID: <20200106134933.u2rblkj7ec4jky6u@development>
Permalink:  ../20200106134933.u2rblkj7ec4jky6u@development/
Also on:    postgresql.org/message-id/20200106134933.u2rblkj7ec4jky6u@development

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, thomas.munro@gmail.com, n.gluhov@postgrespro.ru, beldmit@gmail.com, pgsql-hackers@lists.postgresql.org, alvherre@2ndquadrant.com, dhyan@nataraj.su
  Subject: Re: Ltree syntax improvement
  In-Reply-To: <20200106134933.u2rblkj7ec4jky6u@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox