From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Removing pg_pltemplate and creating "trustable" extensions
Date: Mon, 13 Jan 2020 15:57:57 -0500
Message-ID: <20200113205756.GL3195@tamriel.snowman.net> (raw)
In-Reply-To: <28604.1578947939@sss.pgh.pa.us>
References: <9933.1578599320@sss.pgh.pa.us>
<CAOuzzgr2YXEBsK6oaW-B0PCp7VbQ5XujZ6qFGJbWYgyHkHZxvw@mail.gmail.com>
<12039.1578602021@sss.pgh.pa.us>
<20200110192646.GZ3195@tamriel.snowman.net>
<16979.1578685198@sss.pgh.pa.us>
<CA+TgmoYry3gSXN98s8hVyf8GVzTuqV8WuhCvpxNzMFEOdvx84w@mail.gmail.com>
<20200110205003.GD3195@tamriel.snowman.net>
<27618.1578696790@sss.pgh.pa.us>
<20200113184019.GF3195@tamriel.snowman.net>
<28604.1578947939@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> >> In the meantime, though, this idea as stated doesn't do anything except
> >> let a DB owner grant install privileges to someone else. I'm not even
> >> convinced that we want that, or that anyone needs it (I can recall zero
> >> such requests related to PLs in the past). And for sure it does not
> >> belong in a minimal implementation of this feature.
>
> > Yes, that's what this approach would do. I suppose an alternative would
> > be to lump it in with "CREATE" rights on the DB, but I've advocated and
> > will continue to advocate for splitting up of such broad rights.
> > DB-level CREATE rights currently cover both schemas and publications,
> > for example, even though the two have rather little to do with each
> > other.
>
> The patch as I'm proposing it has nothing to do with "CREATE" rights.
> You're attacking something different from what I actually want to do.
Yes, as an aside, I'm argueing that we should split up the general
CREATE privileges, but I also said that's not required for this.
You're asking "what's the best way to add this privilege to PG?". I'm
saying that it should be done through the privilege system, similar to
publications. I'd prefer it not be lumped into CREATE, but that at
least makes sense to me- adding a default role for this doesn't. I
suppose making it akin to ALTER DATABASE and having it be limited to the
DB owner is also alright (as I said in my last email) but it means that
someone has to be given DB ownership rights in order to install
extensions. I don't really see CREATE EXTENSION as being like ALTER
DATABASE from a privilege perspective, but having it be DB owner still
makes more sense than a default role for this.
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20200113205756.GL3195@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, peter.eisentraut@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Removing pg_pltemplate and creating "trustable" extensions
In-Reply-To: <20200113205756.GL3195@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox