From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: progress report for ANALYZE
Date: Thu, 16 Jan 2020 09:19:31 -0600
Message-ID: <20200116151930.GM26045@telsasoft.com> (raw)
In-Reply-To: <20200115171110.GA19785@alvherre.pgsql>
References: <173a3e8c-af2a-b87a-5126-97c50c4c38dc@nttcom.co.jp_1>
<20200115171110.GA19785@alvherre.pgsql>
On Wed, Jan 15, 2020 at 02:11:10PM -0300, Alvaro Herrera wrote:
> I just pushed this after some small extra tweaks.
>
> Thanks, Yamada-san, for seeing this to completion!
Find attached minor fixes to docs - sorry I didn't look earlier.
Possibly you'd also want to change the other existing instances of "preparing
to begin".
Attachments:v1-0001-Doc-review-for-ANALYZE-progress-a166d408.patch (text/x-diff, 2.4K) download
From de108e69b5d33c881074b0a04697d7061684f823 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Wed, 15 Jan 2020 23:10:29 -0600
Subject: [PATCH v1] Doc review for ANALYZE progress (a166d408)
---
doc/src/sgml/monitoring.sgml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgmlindex 8b44fb1..10871b7 100644--- a/doc/src/sgml/monitoring.sgml+++ b/doc/src/sgml/monitoring.sgml@@ -3525,7 +3525,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<para>
Whenever <command>ANALYZE</command> is running, the
<structname>pg_stat_progress_analyze</structname> view will contain a
- row for each backend that is currently running that command. The tables+ row for each backend currently running <command>ANALYZE</command>. The tables
below describe the information that will be reported and provide
information about how to interpret it.
</para>
@@ -3635,7 +3635,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<row>
<entry><literal>initializing</literal></entry>
<entry>
- The command is preparing to begin scanning the heap. This phase is+ The command is preparing to scan the heap. This phase is
expected to be very brief.
</entry>
</row>
@@ -3643,7 +3643,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<entry><literal>acquiring sample rows</literal></entry>
<entry>
The command is currently scanning the table given by
- <structfield>current_relid</structfield> to obtain sample rows.+ <structfield>relid</structfield> to obtain sample rows.
</entry>
</row>
<row>
@@ -3659,14 +3659,14 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<row>
<entry><literal>computing statistics</literal></entry>
<entry>
- The command is computing statistics from the samples rows obtained during+ The command is computing statistics from the sample rows obtained during
the table scan.
</entry>
</row>
<row>
<entry><literal>computing extended statistics</literal></entry>
<entry>
- The command is computing extended statistics from the samples rows obtained+ The command is computing extended statistics from the sample rows obtained
durring the table scan.
</entry>
</row>
--
2.7.4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, alvherre@2ndquadrant.com, tatsuro.yamada.tf@nttcom.co.jp, amitlangote09@gmail.com, vignesh21@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: progress report for ANALYZE
In-Reply-To: <20200116151930.GM26045@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox