pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Julien Rouhaud <rjuju123@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Guillaume Lelarge <guillaume@lelarge.info>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Expose lock group leader pid in pg_stat_activity
Date: Wed, 5 Feb 2020 07:57:20 +0100
Message-ID: <20200205065720.GA31242@nol> (raw)
In-Reply-To: <20200205014831.GC23913@paquier.xyz>
References: <20200116074912.GA98418@paquier.xyz>
	<CAOBaU_ZPHkriFVYF=OrFyLsrXzcdzPizr0SPh+QdNBsHjT2GmQ@mail.gmail.com>
	<20200118025102.GB230692@paquier.xyz>
	<CAOBaU_Z6WcT8FJfcCMU_Bp+PTzUpTEY9BfBQE4gbGKpE5wpfwQ@mail.gmail.com>
	<20200128130910.anay3mlhaminob6w@development>
	<CAOBaU_YpsBA2puV8NtjV_Oit2jbt=wnNSA_2E41kGUi_BhA8rA@mail.gmail.com>
	<20200128135208.6tnr72gamv2dr262@development>
	<20200130130301.GC130922@paquier.xyz>
	<20200204142725.GA30965@nol>
	<20200205014831.GC23913@paquier.xyz>

On Wed, Feb 05, 2020 at 10:48:31AM +0900, Michael Paquier wrote:
> On Tue, Feb 04, 2020 at 03:27:25PM +0100, Julien Rouhaud wrote:
> > I added some code comments to remind that we don't guarantee any consistency
> > here.
> 
> That's mostly fine.  I have moved the comment related to
> AuxiliaryPidGetProc() within the inner part of its the "if" (or the
> comment should be changed to be conditional).  An extra thing is that
> nulls[29] was not set to true for a user without the proper permission
> rights.

Oh, oops indeed.

> Does that look fine to you?

This looks good, thanks a lot!





view thread (30+ messages)  latest in thread

Message-ID: <20200205065720.GA31242@nol>
Permalink:  ../20200205065720.GA31242@nol/
Also on:    postgresql.org/message-id/20200205065720.GA31242@nol

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: rjuju123@gmail.com, michael@paquier.xyz, tomas.vondra@2ndquadrant.com, sk@zsrv.org, guillaume@lelarge.info, pgsql-hackers@lists.postgresql.org
  Subject: Re: Expose lock group leader pid in pg_stat_activity
  In-Reply-To: <20200205065720.GA31242@nol>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox