From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_regress cleans up tablespace twice.
Date: Thu, 20 Feb 2020 14:23:22 +0900
Message-ID: <20200220052322.GI2288@paquier.xyz> (raw)
In-Reply-To: <9977.1582146393@sss.pgh.pa.us>
References: <20200219.142519.437573253063431435.horikyota.ntt@gmail.com>
<9977.1582146393@sss.pgh.pa.us>
On Wed, Feb 19, 2020 at 04:06:33PM -0500, Tom Lane wrote:
> I think the existing coding dates from before we had a Perl driver for
> this, or else we had it but there were other less-functional ways to
> replace "make check" on Windows. +1 for taking the code out of
> pg_regress.c --- but I'm not in a position to say whether the other
> part of your patch is sufficient.
Removing this code from pg_regress.c makes also sense to me. Now, the
patch breaks "vcregress installcheck" as this is missing to patch
installcheck_internal() for the tablespace path creation. I would
also recommend using a full path for the directory location to avoid
any potential issues if this code is refactored or moved around, the
patch now relying on the current path used.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_regress cleans up tablespace twice.
In-Reply-To: <20200220052322.GI2288@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox