From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_trigger.tgparentid
Date: Tue, 25 Feb 2020 11:00:55 -0300
Message-ID: <20200225140055.GA1669@alvherre.pgsql> (raw)
In-Reply-To: <CA+HiwqF30bLyyxwUKGhTUwySACAioUTy2tUXfbh5-4_668XFdA@mail.gmail.com>
On 2020-Feb-25, Amit Langote wrote:
> On Tue, Feb 25, 2020 at 3:58 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > Thanks for pointing this out -- I agree it needed rewording. I slightly
> > adjusted your text like this:
> >
> > * Internal triggers require careful examination. Ideally, we don't
> > * clone them. However, if our parent is itself a partition, there
> > * might be internal triggers that must not be skipped; for example,
> > * triggers on our parent that are in turn clones from its parent (our
> > * grandparent) are marked internal, yet they are to be cloned.
> >
> > Is this okay for you?
>
> Thanks. Your revised text looks good, except there is a typo:
>
> in turn clones -> in turn cloned
Actually, that was on purpose ... (I also changed "were" to "are" to match.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, amitlangote09@gmail.com, pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: pg_trigger.tgparentid
In-Reply-To: <20200225140055.GA1669@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox