From: Sandro Santilli <strk@kbt.io>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Marking some contrib modules as trusted extensions
Date: Wed, 26 Feb 2020 09:11:21 +0100
Message-ID: <20200226081121.GA5242@liz> (raw)
In-Reply-To: <14514.1581638958@sss.pgh.pa.us>
References: <32315.1580326876@sss.pgh.pa.us>
<20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de>
<13921.1581638230@sss.pgh.pa.us>
<14514.1581638958@sss.pgh.pa.us>
On Thu, Feb 13, 2020 at 07:09:18PM -0500, Tom Lane wrote:
> I wrote:
> > Andres Freund <andres@anarazel.de> writes:
> >> It seems to me that FROM UNPACKAGED shouldn't support trusted.
>
> > Hmm, seems like a reasonable idea, but I'm not quite sure how to mechanize
> > it given that "unpackaged" isn't magic in any way so far as extension.c
> > is concerned. Maybe we could decide that the time for supporting easy
> > updates from pre-9.1 is past, and just remove all the unpackaged-to-XXX
> > scripts? Maybe even remove the "FROM version" option altogether.
>
> [ thinks some more... ] A less invasive idea would be to insist that
> you be superuser to use the FROM option. But I'm thinking that the
> unpackaged-to-XXX scripts are pretty much dead letters anymore. Has
> anyone even tested them in years? How much longer do we want to be
> on the hook to fix them?
PostGIS uses unpackaged-to-XXX pretty heavily, and has it under
automated testing (which broke since "FROM unpackaged" support was
removed, see 14514.1581638958@sss.pgh.pa.us)
We'd be ok with requiring SUPERUSER for doing that, since that's
what is currently required so nothing would change for us.
Instead, dropping UPGRADE..FROM completely puts us in trouble of
having to find another way to "package" postgis objects.
--strk;
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: strk@kbt.io, tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Marking some contrib modules as trusted extensions
In-Reply-To: <20200226081121.GA5242@liz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox