From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Arseny Sher <a.sher@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: logical copy_replication_slot issues
Date: Tue, 17 Mar 2020 16:24:48 -0300
Message-ID: <20200317192448.GA14979@alvherre.pgsql> (raw)
In-Reply-To: <CA+fd4k5qWBLTqomDxfeEeLR-yBf9_+EHxfFcpnP8hc7Bg15OEg@mail.gmail.com>
Thanks Arseny and Masahiko, I pushed this patch just now. I changed
some comments while at it, hopefully they are improvements.
On 2020-Mar-09, Masahiko Sawada wrote:
> ctx = CreateInitDecodingContext(plugin, NIL,
> - false, /* do not build snapshot */
> + false, /* do not build data snapshot */
> restart_lsn,
> logical_read_local_xlog_page, NULL, NULL,
> NULL);
>
> I'm not sure this change makes the comment better. Could you elaborate
> on the motivation of this change?
I addressed this issue by adding a comment in CreateInitDecodingContext
to explain the parameter, and then reference that comment's terminology
in this call. I think it ends up clearer overall -- not that this whole
area is at all particularly clear.
Thanks again.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, masahiko.sawada@2ndquadrant.com, a.sher@postgrespro.ru
Subject: Re: logical copy_replication_slot issues
In-Reply-To: <20200317192448.GA14979@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox