From: Julien Rouhaud <rjuju123@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Christoph Berg <myon@debian.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Douglas Doole <dougdoole@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Collation versioning
Date: Wed, 18 Mar 2020 22:02:29 +0100
Message-ID: <20200318210229.6hweb7y2e3fkwunq@nol> (raw)
In-Reply-To: <c0514679-2a96-39ca-c0b7-99f61f3331cf@2ndquadrant.com>
References: <20200312140026.GA1689@nol>
<20200316075738.GE2331@paquier.xyz>
<20200316140520.GA21497@nol>
<20200317063749.GF2206@paquier.xyz>
<20200317071928.psjiklzvkgqpl3dd@nol>
<20200317104234.GA89737@nol>
<fd8d4475-85ad-506f-2dda-f4d6e66785bc@2ndquadrant.com>
<20200317163147.GA1337480@msg.df7cb.de>
<20200317174351.GB63950@nol>
<c0514679-2a96-39ca-c0b7-99f61f3331cf@2ndquadrant.com>
On Wed, Mar 18, 2020 at 09:29:55PM +0100, Peter Eisentraut wrote:
> On 2020-03-17 18:43, Julien Rouhaud wrote:
> > On Tue, Mar 17, 2020 at 05:31:47PM +0100, Christoph Berg wrote:
> > > Re: Peter Eisentraut 2020-03-17<fd8d4475-85ad-506f-2dda-f4d6e66785bc@2ndquadrant.com>
> > > > Did we discuss the regcollation type? In the current patch set, it's only
> > > > used in two places in a new regression test, where it can easily be replaced
> > > > by a join. Do we need it?
> >
> > I originally wrote it for a previous version of the patchset, to shorten the
> > pg_dump query, but that went out when I replaced the DDL command with native
> > functions instead. It didn't seem to hurt to keep it, so I relied on it in the
> > regression tests.
>
> OK, I have committed the regcollation patch, and some surrounding cleanup of
> the reg* types documentation.
Thanks!
> Note that your patch updated the pg_upgrade documentation to say that tables
> with regcollation columns cannot be upgraded but didn't actually patch the
> pg_upgrade code to make that happen.
Oh right, sorry for that I shouldn't have miss it:(
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com, peter.eisentraut@2ndquadrant.com, myon@debian.org, michael@paquier.xyz, thomas.munro@gmail.com, robertmhaas@gmail.com, laurenz.albe@cybertec.at, dougdoole@gmail.com
Subject: Re: Collation versioning
In-Reply-To: <20200318210229.6hweb7y2e3fkwunq@nol>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox